enhancements: update docs and fix bin #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bebraw
reviewed
May 8, 2017
SCAFFOLDING.md
Outdated
|
|
||
| We ask several questions in the default generator to get you started. | ||
|
|
||
| </hr> |
There was a problem hiding this comment.
I think --- should be the same in Markdown like this:
Testing.
SCAFFOLDING.md
Outdated
|
|
||
| 1. `Will you be creating multiple bundles? (Y/n)` | ||
|
|
||
| What we are meaning here, is if you want to provide your bundle a single or multiple [entry points](https://webpack.js.org/configuration/entry-context/#entry). If you have only one entry to your app, answer yes. If you got more modules you want to bundle, answer no. |
There was a problem hiding this comment.
Can you push the descriptions to the tool itself? Now it's going to be painful to maintain (two places to tweak if you change a question).
There was a problem hiding this comment.
I think the default generator is going to be like it is now, more or less
bin/webpack.js
Outdated
| const filePaths = argv._; | ||
| if(argv._.includes('init')) { | ||
| const initPkgs = argv._.length === 1 ? [] : [argv._.pop()]; | ||
| return require('../lib/initialize')(initPkgs); |
There was a problem hiding this comment.
I would add a newline before return to improve readability.
bin/webpack.js
Outdated
| const initPkgs = argv._.length === 1 ? [] : [argv._.pop()]; | ||
| return require('../lib/initialize')(initPkgs); | ||
| } else if(argv._.includes('migrate')) { | ||
| const filePaths = argv._.length === 1 ? [] : [argv._.pop()]; | ||
| if (!filePaths.length) { |
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "webpack-cli", | |||
| "version": "1.3.0", | |||
| "version": "1.3.1", | |||
There was a problem hiding this comment.
Maybe leave version bump for a separate commit?
bebraw
approved these changes
May 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates documentation to use
webpack-cli initinstead ofwebpack-cli --initand fixes thebinfolder accordingly.